Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor torii grpc #1186

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Refactor torii grpc #1186

merged 9 commits into from
Nov 16, 2023

Conversation

broody
Copy link
Collaborator

@broody broody commented Nov 14, 2023

  • Move query types from dojo-types to torii
  • Subscription query only takes key clause
  • Renamed EntityQuery to Query

Subscription endpoint message changed from

"queries" : [
    {
        "model" : "ModelName",
        "clause" : {
            "keys" : {
                "keys" : [ ... ]
            }
        }
    }
]

to

"entities_keys": [
    {
        "model": "ModelName",
        "keys": [ ... ]
    }
]

@broody broody marked this pull request as ready for review November 15, 2023 00:23
Copy link
Contributor

@tarrencev tarrencev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/torii/grpc/src/types.rs Outdated Show resolved Hide resolved
crates/torii/grpc/src/server/mod.rs Outdated Show resolved Hide resolved
@tarrencev tarrencev merged commit 2b3efb2 into main Nov 16, 2023
12 checks passed
@tarrencev tarrencev deleted the toriigrpc2 branch November 16, 2023 00:20
kariy pushed a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants