-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: catch fetch enpoint error #371
Conversation
WalkthroughThe pull request introduces a patch for the Changes
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.changeset/serious-readers-brush.md (1)
5-5
: Fix grammatical issues in the description.The description has grammatical issues. Consider rephrasing it to:
"Catch error when unsuccessfully fetching 'dev_predeployedAccounts' endpoint"-Catch error when unsuccessfully fetch 'dev_predeployedAccounts' endpoint +Catch error when unsuccessfully fetching 'dev_predeployedAccounts' endpoint🧰 Tools
🪛 LanguageTool
[uncategorized] ~5-~5: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...ch --- Catch error when unsuccessfully fetch 'dev_predeployedAccounts' endpoint(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
packages/predeployed-connector/src/index.ts (1)
24-33
: LGTM! Consider enhancing error logging.The error handling implementation looks good. It properly catches errors and provides a safe fallback. However, the error logging could be more descriptive.
Consider enhancing the error message to provide more context:
- console.warn( - "Failed to get `dev_predeployedAccounts` endpoint", - error - ); + console.warn( + "Failed to fetch from `dev_predeployedAccounts` endpoint. Returning empty array.", + error + );
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.changeset/serious-readers-brush.md
(1 hunks)packages/predeployed-connector/src/index.ts
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
.changeset/serious-readers-brush.md
[uncategorized] ~5-~5: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...ch --- Catch error when unsuccessfully fetch 'dev_predeployedAccounts' endpoint
(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: check
- GitHub Check: build
Closes #
Introduced changes
Checklist
Summary by CodeRabbit