Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burner remove options #37

Merged
merged 6 commits into from
Nov 1, 2023

Conversation

Matth26
Copy link
Contributor

@Matth26 Matth26 commented Oct 27, 2023

  • Introduced a BurnerProvider within create-burner to allow the passing of initialization variables to useBurner without having to provide them as props.
  • Replaced rpcUrl with rpcProvider and initialized it within the DojoContext. In the past, it was created inside the useBurner constructor. This could lead to confusion since rpc_url was optional and defaulted to http://localhost:5050/ in the burner.

@Matth26 Matth26 marked this pull request as ready for review October 27, 2023 17:32
@Matth26
Copy link
Contributor Author

Matth26 commented Nov 1, 2023

Issue #41 has been fixed when extracting the RpcProvider instantiation from the create-burner package

Issue #38 fixed: add "Save Burners to Clipboard" and a "Restore Burners from Clipboard" buttons in react-app example and add save and restore functions in create-burner package

@ponderingdemocritus
Copy link
Contributor

Looks great!

@ponderingdemocritus ponderingdemocritus merged commit eb68052 into dojoengine:main Nov 1, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants