fix: Issues with users.conf #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Previously, when processing users.conf files in CRLF format, the Bash script treated the '\r' at the end of lines as part of the password. This caused incorrect passwords and login failures. 2.This issue has now been fixed by removing all '\r' characters, enhancing compatibility. 3.It is still recommended to use LF format for both smb.conf and users.conf files.
1.Use pdb_output to first capture the result of pdbedit -s "$cfg" -L, and then check if the user exists in the output. Without this step, the first user loaded may be incorrectly identified as not existing, causing it to be re-added and triggering the log output: "User $username has been added to Samba and password set."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28
I finally found the root cause of the issue:
1.smb.conf and users.conf should be LF files, but if they are CRLF files, the previous bash script would treat the \r before the \n at the end of the line as part of the password. I have added logic to remove the \r character in the latest code, and it is now working properly. However, it is still recommended to use the LF format.
2.Some users have users.conf files that don't have a newline or a blank line at the end, causing the last line's configuration to be unrecognized. This issue was fixed in the last commit, and now all content can be correctly recognized.
3.I noticed that my log output was abnormal. Restarting Docker would output logs showing that the Samba user from the first line of users.conf was being added again. I have also fixed this issue in this update.