-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEAB-6957: Documentation for delete entry feature #264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! We did recently change the UI to remove the "Is not a checked or checker workflow" text from the dialog for notebooks, so you might want to go to qa and capture another image.
.. image:: /assets/images/docs/delete-notebook-dialog.png | ||
:width: 50 % | ||
|
||
After you delete the entry, you must uninstall the Dockstore GitHub App from the source GitHub repo, or edit/remove the .dockstore.yml file so that it no longer describes the deleted entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this tutorial is for deleting GitHub App entries because this step isn't applicable to legacy/hosted tools and workflows. Maybe we should move it to the Dockstore GitHub App section to avoid possible confusion? https://docs.dockstore.org/en/stable/getting-started/github-apps/github-apps-landing-page.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is worth it's own article, could also add this to the list of requirements about though
- Uninstalling the Dockstore GitHub App from the source GitHub repo | ||
|
||
This tutorial walks through the process of deleting entries from Dockstore. | ||
This action is permanent and after you delete the workflow, it will no longer appear on Dockstore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: You're following the dialog text, where I should have noticed it earlier, but it seems little dissonant to on the one hand say it's permanent and will no longer appear on Dockstore, and then there is a section below on how to ensure is doesn't appear again -- that's not permanent. :)
Not sure I have an easy rephrasing in mind, so just something to ponder, and if no other idea comes, ok to leave.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept line to keep consistent with dialog
- Was created on/after April 1, 2022, and | ||
- Is not a checked or checker workflow. | ||
|
||
If your entry does not meet the requirements above, you can archive it using these steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll link the documentation page for archiving in my next PR for https://ucsc-cgl.atlassian.net/browse/SEAB-5979
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I mis-spoke.
I don't think deletion here applies only to GitHub app workflows.
It's just that you only need to remove the app for workflows of that kind when deleting
Description
This PR creates a new documentation page with the steps to delete an entry.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6057
Please make sure that you've checked the following before submitting your pull request. Thanks!