Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-6957: Documentation for delete entry feature #264

Merged
merged 10 commits into from
Jan 31, 2024
Merged

Conversation

hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Jan 26, 2024

Description
This PR creates a new documentation page with the steps to delete an entry.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6057

Please make sure that you've checked the following before submitting your pull request. Thanks!

@hyunnaye hyunnaye marked this pull request as ready for review January 29, 2024 16:47
Copy link
Contributor

@svonworl svonworl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! We did recently change the UI to remove the "Is not a checked or checker workflow" text from the dialog for notebooks, so you might want to go to qa and capture another image.

docs/getting-started/delete-on-dockstore.rst Outdated Show resolved Hide resolved
docs/getting-started/delete-on-dockstore.rst Outdated Show resolved Hide resolved
docs/getting-started/delete-on-dockstore.rst Show resolved Hide resolved
docs/getting-started/delete-on-dockstore.rst Outdated Show resolved Hide resolved
.. image:: /assets/images/docs/delete-notebook-dialog.png
:width: 50 %

After you delete the entry, you must uninstall the Dockstore GitHub App from the source GitHub repo, or edit/remove the .dockstore.yml file so that it no longer describes the deleted entry.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this tutorial is for deleting GitHub App entries because this step isn't applicable to legacy/hosted tools and workflows. Maybe we should move it to the Dockstore GitHub App section to avoid possible confusion? https://docs.dockstore.org/en/stable/getting-started/github-apps/github-apps-landing-page.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is worth it's own article, could also add this to the list of requirements about though

docs/getting-started/delete-on-dockstore.rst Outdated Show resolved Hide resolved
- Uninstalling the Dockstore GitHub App from the source GitHub repo

This tutorial walks through the process of deleting entries from Dockstore.
This action is permanent and after you delete the workflow, it will no longer appear on Dockstore.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You're following the dialog text, where I should have noticed it earlier, but it seems little dissonant to on the one hand say it's permanent and will no longer appear on Dockstore, and then there is a section below on how to ensure is doesn't appear again -- that's not permanent. :)

Not sure I have an easy rephrasing in mind, so just something to ponder, and if no other idea comes, ok to leave.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept line to keep consistent with dialog

- Was created on/after April 1, 2022, and
- Is not a checked or checker workflow.

If your entry does not meet the requirements above, you can archive it using these steps.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll link the documentation page for archiving in my next PR for https://ucsc-cgl.atlassian.net/browse/SEAB-5979

@hyunnaye hyunnaye requested a review from kathy-t January 30, 2024 19:51
Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I mis-spoke.
I don't think deletion here applies only to GitHub app workflows.
It's just that you only need to remove the app for workflows of that kind when deleting

@hyunnaye hyunnaye requested a review from denis-yuen January 30, 2024 20:33
docs/getting-started/delete-on-dockstore.rst Outdated Show resolved Hide resolved
@hyunnaye hyunnaye merged commit 7e64c67 into develop Jan 31, 2024
1 of 2 checks passed
@hyunnaye hyunnaye deleted the feature/SEAB-6057 branch January 31, 2024 17:54
@hyunnaye hyunnaye restored the feature/SEAB-6057 branch January 31, 2024 18:50
@hyunnaye hyunnaye deleted the feature/SEAB-6057 branch January 31, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants