Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGDOCS-2382 #21848

Merged
merged 7 commits into from
Jan 23, 2025
Merged

ENGDOCS-2382 #21848

merged 7 commits into from
Jan 23, 2025

Conversation

aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Jan 17, 2025

Description

Some Compose spec updates:

Adds compose-spec/compose-spec#557
Adds compose-spec/compose-spec#555

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/compose Relates to docker-compose.yml spec or docker-compose binary label Jan 17, 2025
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 156485b
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/678e538d12f85f0008f4c616
😎 Deploy Preview https://deploy-preview-21848--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker marked this pull request as ready for review January 17, 2025 16:06
@aevesdocker aevesdocker requested a review from a team January 17, 2025 16:06
Copy link
Contributor

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with the difference of this document file vs the related PR but you may want to ensure they're in sync? The content is diverging here (and also incorrect in advice).

content/reference/compose-file/services.md Outdated Show resolved Hide resolved
@aevesdocker
Copy link
Contributor Author

@polarathene

I am not familiar with the difference of this document file vs the related PR

The difference can be found here https://docs.docker.com/reference/compose-file/

but you may want to ensure they're in sync?

Yes. Thank you.

@polarathene
Copy link
Contributor

The difference can be found here https://docs.docker.com/reference/compose-file/

No, I was referring to these source files: https://github.com/compose-spec/compose-spec/pull/557/files

At a glance there is overlap, so I wasn't quite familiar with how changes from there make it into the actual Docker docs here.

Copy link
Contributor

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aevesdocker aevesdocker merged commit f1a87f4 into docker:main Jan 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compose Relates to docker-compose.yml spec or docker-compose binary status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants