Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directly support ubuntu based distros in add repository snippet #21749

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

directly support ubuntu based distros in add repository snippet #21749

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a629b94
directly support ubuntu based distros in add repository snippets
nisrael Jan 9, 2025
70d9e60
Merge branch 'docker:main' into patch-1
nisrael Jan 13, 2025
c5c379a
readd, move and rephrase the note regarding Ubuntu derivative distrib…
nisrael Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions content/manuals/engine/install/ubuntu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ versions:
Docker Engine for Ubuntu is compatible with x86_64 (or amd64), armhf, arm64,
s390x, and ppc64le (ppc64el) architectures.

> [!NOTE]
>
> Installation on Ubuntu derivative distributions, such as Linux Mint, is not officially
> supported (though it may work).

### Uninstall old versions

Before you can install Docker Engine, you need to uninstall any conflicting packages.
Expand Down Expand Up @@ -127,17 +132,12 @@ Docker from the repository.
# Add the repository to Apt sources:
echo \
"deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.asc] {{% param "download-url-base" %}} \
$(. /etc/os-release && echo "$VERSION_CODENAME") stable" | \
$(. /etc/os-release && echo "${UBUNTU_CODENAME:-$VERSION_CODENAME}") stable" | \
sudo tee /etc/apt/sources.list.d/docker.list > /dev/null
sudo apt-get update
```

> [!NOTE]
>
> If you use an Ubuntu derivative distribution, such as Linux Mint,
> you may need to use `UBUNTU_CODENAME` instead of `VERSION_CODENAME`.

Comment on lines -130 to -139
Copy link
Contributor

@vvoland vvoland Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'm okay with making it use UBUNTU_CODENAME if available, as long as we keep the notice but change it to warn about derivatives are not supported officially (but MAY work).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rephrased the notice and moved it to the section, where the supported distributions are listed.

2. Install the Docker packages.
3. Install the Docker packages.

{{< tabs >}}
{{< tab name="Latest" >}}
Expand Down Expand Up @@ -173,7 +173,7 @@ Docker from the repository.
{{< /tab >}}
{{< /tabs >}}

3. Verify that the installation is successful by running the `hello-world` image:
4. Verify that the installation is successful by running the `hello-world` image:

```console
$ sudo docker run hello-world
Expand Down
Loading