Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callout to clarify 'Access token' in activity logs #21730

Merged

Conversation

sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Jan 7, 2025

Description

  • The Activity log uses "Access token" to represent PATs and OATs
  • I have added a callout to clarify that "Access token" refers to PATs and OATs

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@sarahsanders-docker sarahsanders-docker requested review from technicallyjosh and a team January 7, 2025 17:31
@github-actions github-actions bot added the area/admin Relates to Docker Admin label Jan 7, 2025
Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 508d07c
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/677ef5136286fd0008b37e1d
😎 Deploy Preview https://deploy-preview-21730--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@craig-osterhout
Copy link
Contributor

craig-osterhout commented Jan 7, 2025

The current note placement appears to reference events in the org events table, which may not be intended. I believe it might be applicable for repository events instead. If so, I recommend moving the note above the repo events table and providing additional context or an example to clarify the applicable events.
A rough example, event descriptions that appear in the UI and include an actor, like "xx pushed to the repo," can refer to a user, PAT, or OAT.

technicallyjosh
technicallyjosh previously approved these changes Jan 8, 2025
content/manuals/admin/organization/activity-logs.md Outdated Show resolved Hide resolved
@sarahsanders-docker sarahsanders-docker merged commit 4baa3c6 into docker:main Jan 8, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin Relates to Docker Admin status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants