-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example that shows the stated "default" settings in json #21596
base: main
Are you sure you want to change the base?
Conversation
(also fix an errant . )
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
.... I see the lint error, but I'm also not convinced this feature actually works. I'm gonna open a bug to clarify. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, but I would like to wait with this change. The buildkitd gc config has changed in v0.18, and so has the defaults. While that version doesn't yet ship with Docker Engine, it soon will and I'll need to make space for both the old and the new config format (incl. buildkitd and daemon.json)
Inaccuracy on my part, the buildkitd toml config actually changed in v0.17 so it is in the latest version of docker engine. I'll address these updates separately. |
So that would also address moby/buildkit#5581 ? With the == / = behavior? |
Hmm, no I don't think the filters are affected by the new config options. KeepBytes was replaced by three, more configurable options in v0.17. GC config via daemon.json does not yet use all of these new options. But I don't believe filtering was changed, it only gave new ways to define the GC threshold (min reserved bytes, maximum used space, min free disk space) |
(also fix an errant . )
Description
Add an example that matches the stated defaults.
It isn't obvious from current docs that json requires only a single '=' sign. Also the "type" settings all need to be in one string, so this gives an example showing that.