Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example that shows the stated "default" settings in json #21596

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rrauenza
Copy link
Contributor

@rrauenza rrauenza commented Dec 9, 2024

(also fix an errant . )

Description

Add an example that matches the stated defaults.

It isn't obvious from current docs that json requires only a single '=' sign. Also the "type" settings all need to be in one string, so this gives an example showing that.

@github-actions github-actions bot added the area/build Relates to Dockerfiles or docker build command label Dec 9, 2024
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 39e6af4
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/675746718f1eb0000879b951
😎 Deploy Preview https://deploy-preview-21596--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rrauenza
Copy link
Contributor Author

rrauenza commented Dec 9, 2024

.... I see the lint error, but I'm also not convinced this feature actually works.

I'm gonna open a bug to clarify.

Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, but I would like to wait with this change. The buildkitd gc config has changed in v0.18, and so has the defaults. While that version doesn't yet ship with Docker Engine, it soon will and I'll need to make space for both the old and the new config format (incl. buildkitd and daemon.json)

@dvdksn
Copy link
Collaborator

dvdksn commented Dec 10, 2024

Inaccuracy on my part, the buildkitd toml config actually changed in v0.17 so it is in the latest version of docker engine.

I'll address these updates separately.

@rrauenza
Copy link
Contributor Author

So that would also address moby/buildkit#5581 ? With the == / = behavior?

@dvdksn
Copy link
Collaborator

dvdksn commented Dec 11, 2024

Hmm, no I don't think the filters are affected by the new config options. KeepBytes was replaced by three, more configurable options in v0.17. GC config via daemon.json does not yet use all of these new options. But I don't believe filtering was changed, it only gave new ways to define the GC threshold (min reserved bytes, maximum used space, min free disk space)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants