Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Configure and Connect SSO docs #21211

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Update Configure and Connect SSO docs #21211

merged 6 commits into from
Oct 24, 2024

Conversation

sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Oct 22, 2024 •
edited by jira bot
Loading

Description

What's changing?

  • Configure guide was reworked to include configuration on the Docker side only. This is to minimize jumping back and forth between multiple guides and multiple platforms (Docker and IdP).
  • Connect guide was reworked to include all the steps to connect SSO in Docker, your IdP, then cross-connect the two. A callout was added to recommend that users do this in one session and have multiple windows open to make copying and pasting values easier between Docker and their IdP. I am open to feedback on how to better reword this/give this recommendation!
  • Broken links checked and updated across multiple guides

Related issues or tickets

ENGDOCS-2264

Reviews

@docker/iam-team @francesco-corti

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added area/security area/admin Relates to Docker Admin labels Oct 22, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 22, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 07d6ce0
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/671ac528b8f8f60008834500
😎 Deploy Preview https://deploy-preview-21211--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarahsanders-docker sarahsanders-docker marked this pull request as ready for review October 23, 2024 00:08
@sarahsanders-docker sarahsanders-docker requested a review from a team October 23, 2024 00:08
@sarahsanders-docker sarahsanders-docker removed the request for review from aevesdocker October 24, 2024 17:47
craig-osterhout
craig-osterhout reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

content/manuals/security/for-admins/single-sign-on/connect.md Outdated Show resolved Hide resolved
content/manuals/security/for-admins/single-sign-on/connect.md Outdated Show resolved Hide resolved
craig-osterhout
craig-osterhout approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahsanders-docker sarahsanders-docker merged commit d126656 into docker:main Oct 24, 2024
13 of 14 checks passed
@sarahsanders-docker sarahsanders-docker deleted the ENGDOCS-2264 branch December 18, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-osterhout craig-osterhout craig-osterhout approved these changes

Assignees
No one assigned
Labels
area/admin Relates to Docker Admin area/security status/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahsanders-docker @craig-osterhout