Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSO overview doc for clarity #21197

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Oct 21, 2024

Description

What's changing?

The “How to set it up” section will be rewritten to reflect each step as a standalone step, making it clear what exact steps need to take place to configure single sign-on. This will allow users to break the process up into individual tasks, with the ability to complete each one and follow along to the next.

Related issues or tickets

ENGDOCS-2262

Reviews

  • Editorial review

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 80f8c9f
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6717c0fb10c2d50008c5350a
😎 Deploy Preview https://deploy-preview-21197--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarahsanders-docker
Copy link
Contributor Author

@dvdksn I am confused by the linting error I am getting on this PR. I ran the command locally and the response is confusing to me because I do not reference the release URL in this markdown file: zsh: event not found: content/manuals/engine/release

any thoughts?

Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahsanders-docker sarahsanders-docker merged commit befd9b0 into docker:main Oct 22, 2024
14 checks passed
@sarahsanders-docker sarahsanders-docker deleted the ENGDOCS-2262 branch October 22, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants