Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker Scout: update policy names #20537

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Docker Scout: update policy names #20537

merged 3 commits into from
Aug 6, 2024

Conversation

dvdksn
Copy link
Collaborator

@dvdksn dvdksn commented Aug 5, 2024

Description

  • scout: remove duplicate section for quality gates passed policy
  • scout: update policy names
  • redirect: add go links with static policy ids

Related issues or tickets

https://docker.atlassian.net/browse/SDC-1162

@github-actions github-actions bot added area/build Relates to Dockerfiles or docker build command area/scout Relates to Docker Scout labels Aug 5, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 5, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 5a8d161
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66b0d629ff38760008891b88
😎 Deploy Preview https://deploy-preview-20537--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn force-pushed the scout-policy-names branch from 3328a46 to f50ba80 Compare August 5, 2024 13:10
@dvdksn dvdksn marked this pull request as ready for review August 5, 2024 13:21
@dvdksn dvdksn requested a review from crazy-max as a code owner August 5, 2024 13:21
chrispatrick
chrispatrick approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@chrispatrick chrispatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

felipecruz91
felipecruz91 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@felipecruz91 felipecruz91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like having IDs to identify the policies given how susceptible the names are to change. I've add a minor comment, otherwise LGTM.

content/scout/policy/_index.md Outdated Show resolved Hide resolved
@dvdksn dvdksn requested a review from a team August 5, 2024 13:30
@dvdksn dvdksn force-pushed the scout-policy-names branch from f50ba80 to 5a8d161 Compare August 5, 2024 13:39
@dvdksn dvdksn merged commit 0d5f756 into docker:main Aug 6, 2024
12 checks passed
@dvdksn dvdksn deleted the scout-policy-names branch August 6, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aevesdocker aevesdocker aevesdocker approved these changes

@felipecruz91 felipecruz91 felipecruz91 approved these changes

@chrispatrick chrispatrick chrispatrick approved these changes

@crazy-max crazy-max Awaiting requested review from crazy-max

Assignees
No one assigned
Labels
area/build Relates to Dockerfiles or docker build command area/scout Relates to Docker Scout status/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dvdksn @chrispatrick @felipecruz91 @aevesdocker