update the demo code #20530
update the demo code #20530
Conversation
I ran a demo following the code marked in the file, but found that the types.StartOptions has been deprecated, so help to update the demo code.
github-actions
bot
added
area/engine
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| } | ||
|
|
||
| stdcopy.StdCopy(os.Stdout, os.Stderr, out) | ||
| ctx := context.Background() |
There was a problem hiding this comment.
For others reviewing; the large number of lines changes is due to spaces -> tabs. Go uses tabs for indenting, but let me double-check with @dvdksn if there perhaps was a reason to use spaces for the docs (maybe for formatting reasons)?
To review the changes with whitespace changes hidden, add ?w=1 to the URL; https://github.com/docker/docs/pull/20530/files?w=1
|
Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a Prevent pull requests from auto-closing with a /lifecycle stale |
There was a problem hiding this comment.
ah, this PR went below my radar for some reason. It looks like this change was already implemented in #21116
As for tabs vs spaces, I think it's just a formatter thing - according to the commonmark spec, tabs and spaces are both allowed. But formatters might just convert tabs to 4 spaces.
I ran a demo following the code marked in the file, but found that the types.StartOptions has been deprecated, so help to update the demo code.
Description
ran the code in my local
Related issues or tickets
Reviews