Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Underscores (_) and slashes (/) to valid label content #20510

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

maxmynter
Copy link
Contributor

@maxmynter maxmynter commented Jul 31, 2024

Description

We're building a tool that wraps container creation and found that Docker can also work with underscores as well as slashes in labels.

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/configuration labels Jul 31, 2024
Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit bc34457
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66aa43da46c63900084c4fd1
😎 Deploy Preview https://deploy-preview-20510--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

as docker can work with them.
@maxmynter maxmynter force-pushed the underscore-labels branch from f97f2ac to 5726401 Compare July 31, 2024 12:12
@maxmynter maxmynter changed the title Add Underscores (_) to valid label content Add Underscores (_) and slashes (/) to valid label content Jul 31, 2024
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dvdksn dvdksn merged commit e135e5f into docker:main Aug 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issue affects Docker engine/daemon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants