Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eggdrop: Add new ENV variables to docs #2392

Closed
wants to merge 10 commits into from

Conversation

vanosg
Copy link
Contributor

@vanosg vanosg commented Nov 15, 2023

No description provided.

@LaurentGoderre LaurentGoderre changed the title Add new ENV variables to docs Eggdrop: Add new ENV variables to docs Nov 15, 2023
@LaurentGoderre
Copy link
Member

@vanosg could you try squashing/rebasing the commits down to 1?

@vanosg
Copy link
Contributor Author

vanosg commented Nov 15, 2023

I don't know that I can once I've pushed it to my remote (without re-writing history). Do you have the option for 'Squash and Merge' under the drop down arrow on the merge button for this PR? Happy to try other options if you have suggestions, but I'd rather not re-write history if possible. Thanks!

@vanosg
Copy link
Contributor Author

vanosg commented Nov 29, 2023

Hi @LaurentGoderre - are you able to squash this as you merge or no? Appreciate any feedback, thanks!

@tianon
Copy link
Member

tianon commented Nov 30, 2023

For the next PR, I'd suggest cloning https://github.com/docker-library/docs.git (instead of your fork), making your changes on that, then pushing them to your fork (either by adding a remote or something like git push [email protected]:eggheads/docs.git HEAD:some-branch-name) which will then print out a URL for opening a PR too.

@winnieconnors

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants