Scope global styles to do-bulma class #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
MattIPv4
force-pushed
the
MattIPv4/scope-styles
branch
2 times, most recently
from
963835f to
466081c
Compare
MattIPv4
force-pushed
the
MattIPv4/scope-styles
branch
from
466081c to
29d03f7
Compare
davidcarlsonberg
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Global styles
What issue does this relate to?
N/A
What should this PR do?
Scopes the previously truly global styles to only be global in the context of the do-bulma wrapper class. This ensures that when used in the context of a DigitalOcean WWW/Community template, fonts etc. set by do-bulma don't interfere with the overall page.
What are the acceptance criteria?
Demo continues to build and look as expected. Fonts in DigitalOcean header/footer are correct and match the actual site.