Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/77 fmu tools page #88

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Enh/77 fmu tools page #88

merged 5 commits into from
Dec 19, 2024

Conversation

StephanieKemna
Copy link
Collaborator

Description

Resolves #77

Add a README to Examples page, add generated FMU files for examples.

Developer Checklist (before requesting PR review)

  • [n/a] My code follows the style guidelines of this project
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

I have:

  • [n/a] commented my code, particularly in hard-to-understand areas
  • performed a self-review of my own code
  • not committed unnecessary formatting changes, thereby occluding the actual changes (e.g. change of tab spacing, eol, etc.)
  • made corresponding changes to the documentation
  • added change to CHANGELOG.md
  • [n/a] added tests that prove my fix is effective or that my feature works (for core features)

Reviewer checklist

I have:

  • have performed a review of the code
  • tested that the software still works as expected
  • checked updates to documentation
  • checked that the CHANGELOG is updated

@StephanieKemna StephanieKemna added the documentation Improvements or additions to documentation label Dec 19, 2024
@StephanieKemna StephanieKemna self-assigned this Dec 19, 2024
Copy link
Collaborator

@KristofferSkare KristofferSkare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just thinking if we should fix issues with the generated source files in this same PR or if we should make a new one to fix them.

examples/README.md Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
@StephanieKemna StephanieKemna merged commit 4fdbc85 into main Dec 19, 2024
10 checks passed
@StephanieKemna StephanieKemna deleted the enh/77-fmu-tools-page branch December 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get listed on the FMI tools page
2 participants