Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outputs in generated modelDescription.xml #87

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

KristofferSkare
Copy link
Collaborator

@KristofferSkare KristofferSkare commented Dec 18, 2024

Description

Resolves #86

Currently the generated FMUs does not pass the fmu checker.
This is now fixed by making two changes to the generation of the modelDescription.xml:

  1. Adding the missing tag for the outputs
  2. Changing attribute index for to be 1-indexed from being 0-indexed.
  3. Change the order of the variables to be added sorted by their valueReference

How Has This Been Tested?

  • Generated the example FMUs and checked them using the fmu checker.

Screenshots (if appropriate)

Developer Checklist (before requesting PR review)

  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

I have:

  • commented my code, particularly in hard-to-understand areas
  • performed a self-review of my own code
  • not committed unnecessary formatting changes, thereby occluding the actual changes (e.g. change of tab spacing, eol, etc.)
  • made corresponding changes to the documentation
  • added change to CHANGELOG.md
  • added tests that prove my fix is effective or that my feature works (for core features)

Reviewer checklist

I have:

  • performed a self-review of my own code have performed a review of the code
  • tested that the software still works as expected
  • checked updates to documentation
  • checked that the CHANGELOG is updated

@KristofferSkare KristofferSkare self-assigned this Dec 18, 2024
@KristofferSkare KristofferSkare linked an issue Dec 18, 2024 that may be closed by this pull request
@StephanieKemna StephanieKemna added the bug Something isn't working label Dec 19, 2024
@StephanieKemna StephanieKemna merged commit 6a42062 into main Dec 19, 2024
10 checks passed
@StephanieKemna StephanieKemna deleted the fix/86-outputs-in-generated-model-description branch December 19, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix <Outputs> in generated modelDescription.xml
2 participants