Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare MLFMU for open-source release #75

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

Jorgelmh
Copy link
Collaborator

@Jorgelmh Jorgelmh commented Nov 8, 2024

Description

Resolves #issue_nr

...

How Has This Been Tested?

  • Test A
  • Test B

Screenshots (if appropriate)

Developer Checklist (before requesting PR review)

  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

I have:

  • commented my code, particularly in hard-to-understand areas
  • performed a self-review of my own code
  • not committed unnecessary formatting changes, thereby occluding the actual changes (e.g. change of tab spacing, eol, etc.)
  • made corresponding changes to the documentation
  • added change to CHANGELOG.md
  • added tests that prove my fix is effective or that my feature works (for core features)

Reviewer checklist

I have:

  • performed a self-review of my own code have performed a review of the code
  • tested that the software still works as expected
  • checked updates to documentation
  • checked that the CHANGELOG is updated

Copy link
Collaborator

@StephanieKemna StephanieKemna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. Maybe @MelihAkdag wants to have a quick look at the notebook?

@Jorgelmh Jorgelmh merged commit 872e055 into main Nov 8, 2024
10 checks passed
@StephanieKemna StephanieKemna deleted the enhance/prepare-open-source branch November 8, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants