-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more unit tests #63
Conversation
…variables to start from 0
…variables to start from 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Just some minor comments and a suggestion on how the errors can be handled better with pytest.
Use new syntax for Union and Optinal Co-authored-by: KristofferSkare <[email protected]>
I think the pydantic dependency is not included - several files complain that pydantic could not be resolved. |
I did a I but still think something is wrong with the uv venv though, since it should not need that. So doubting a bit the venv. I even manually activated the venv before trying to test this PR, but no difference. |
@Jorgelmh |
@Jorgelmh Then also matplotlib can be removed as a dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment, but it is not important
Description
Resolves #12
Add unit tests for the validation of the interface JSON, the modelDescription builder and the template data generated for the CPPFMU code.
How Has This Been Tested?
Screenshots (if appropriate)
Developer Checklist (before requesting PR review)
I have:
Reviewer checklist
I have: