Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to README and conanfile #59

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

StephanieKemna
Copy link
Collaborator

Developer/PR creator checklist

I have:

  • [N/A] commented my code, particularly in hard-to-understand areas
  • performed a self-review of my own code
  • not committed unnecessary formatting changes, thereby occluding the actual changes (e.g. change of tab spacing, eol, etc.)
  • [N/A] made corresponding changes to the documentation
  • [N/A] added change to CHANGELOG.md
  • [N/A] added tests that prove my fix is effective or that my feature works (for core features)

Reviewer checklist

I have:

  • performed a self-review of my own code have performed a review of the code
  • tested that the software still works as expected
  • checked updates to documentation
  • checked that the CHANGELOG is updated

Copy link
Collaborator

@KristofferSkare KristofferSkare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@StephanieKemna StephanieKemna merged commit db44d49 into main Oct 17, 2024
22 checks passed
@StephanieKemna StephanieKemna deleted the README_minor_fixes branch November 8, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants