-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstrings with help from copilot #52
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9e65e09
add docstrings with help from copilot
StephanieKemna 35fb83c
Address some of Jorge's comments to new docstrings
StephanieKemna 30be888
Merge remote-tracking branch 'origin/main' into 32-write-missing-docu…
StephanieKemna d2741b2
Address Jorge's comments re. agent_state_init_indexes and class args
StephanieKemna 1b8cb3a
Update CHANGELOG
StephanieKemna 1a30427
Update src/mlfmu/fmu_build/templates/fmu/fmu_template.cpp
StephanieKemna 91a103a
Update src/mlfmu/fmu_build/templates/fmu/fmu_template.cpp
StephanieKemna 6ffef30
Update src/mlfmu/fmu_build/templates/fmu/fmu_template.cpp
StephanieKemna a0699d6
Update src/mlfmu/fmu_build/templates/onnx_fmu/onnxFmu.cpp
StephanieKemna a50a6bd
remove examples from python package template, which are not used
StephanieKemna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is a bit weird since it is a template string file and a cpp file at the same time. I see that some linting has made some changes that I think breaks its use as a template string. I suggest some changes below to fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, suggestions accepted, and template/examples removed. Let me know if there's more!
Thanks for making the suggestions as you did, it was super easy to just accept/commit those :)