33 cleanup after building errors #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to crlf on save, because not all files are crlf.
…inimum required version to get rid of warning about that
… dir, remove debugger printouts
Jorgelmh
reviewed
Jul 22, 2024
Jorgelmh
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #33 , see comments on that issue.
There are more changes than just the fix. The fix is mainly the chdir.
In addition, I added more error handling, logging, comments/docstrings, and some shorthands for commandline arguments.
Also changed how temporary dir was created, only create it once, and use the path str further. Also removed delete_build_folders, because they will automatically be deleted anyway (temp dir goes out of scope), and it seemed the argument was not really used in the code.