-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialization of state in onnx fmu #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Jorgelmh
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great implementation! I like the possibility of implementing inputs as initializers for internal states, just need to evaluate how we can do this with the already existing implementation and logic behind FMU inputs (refer to my other comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
This PR introduces the possibility to initialize the state of the generated mlfmu using automatically generated fmu parameters from the interface json.
The interface is changed by expanding the
InternalState
filed to include an optionalstart_value
. Ifstart_value
is set then parameters for initialization is generated for all the states corresponding to theagent_output_indexes
. If initialization is usedname
arg also has to be set to something. This will be the name of the automatically generated parameter.This is done by generating a parameter for each state that should be possible to initialize with a name given by the interface.
The generated parameters (
FmiInputVariable
) are given a new argument (agent_state_init_indexes
) that specify with index in the state array that should be initialized with this parameter. This arg is set automatically from the interface.json. Since this is a arg ofFmiInputVariable
, any FMU input or parameter could, in principle, be used to initialize state. But for now there is no way for a normal fmu input/parameter to have this argument set to something. So a future improvement could be to open up the possibility of normal fmu inputs and parameters to be used to initialize state.