Update dependencies 20250107 #139
Conversation
WalkthroughThe pull request involves updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
14-14: Consider documenting API endpointsSince
aggrec/openapi.yamlhas been removed, consider adding alternative API documentation to maintain visibility of the service's endpoints and functionality.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
🔇 Additional comments (1)
pyproject.toml (1)
14-14: Verify breaking changes in dnstapir v1.2.1The update from v1.0.1 to v1.2.1 and addition of "keymanager" extra might introduce breaking changes. Please ensure:
- The new version is compatible with your current implementation
- Required changes for the new "keymanager" functionality are implemented
Let's verify the changes and potential impacts:
✅ Verification successful
Dependencies and configuration are properly aligned
The update to dnstapir v1.2.1 with "keymanager" and "opentelemetry" extras is justified by:
- OpenTelemetry configuration in aggrec.toml and supporting services
- Key management configuration (key_cache) and valkey service presence
- Dynamic OpenAPI spec generation replacing the static yaml file
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check dnstapir changelog and related changes # Check if there are any imports or usage of keymanager functionality rg -l "from dnstapir.*keymanager" || echo "No keymanager imports found" # Look for potential breaking changes in implementation rg -l "from dnstapir import" -A 3 || echo "No dnstapir imports found" # Check for any remaining OpenAPI references after openapi.yaml removal rg -l "openapi\.yaml" || echo "No references to openapi.yaml found"Length of output: 277
Script:
#!/bin/bash # Check content of files referencing openapi.yaml echo "=== Content of tools/export_openapi_yaml.py ===" cat tools/export_openapi_yaml.py || echo "File not found" echo -e "\n=== References in README.md ===" rg "openapi\.yaml" README.md -C 2 || echo "No matches in README.md" echo -e "\n=== References in aggrec/extras.py ===" rg "openapi\.yaml" aggrec/extras.py -C 2 || echo "No matches in aggrec/extras.py" # Check if dnstapir was previously in pyproject.toml echo -e "\n=== Previous dnstapir references in pyproject.toml ===" git grep -l "dnstapir" $(git rev-parse HEAD^) -- pyproject.toml || echo "No previous references found"Length of output: 1044
Script:
#!/bin/bash # Check for plugin/entry point usage echo "=== Entry points in pyproject.toml ===" rg "entry_points|plugins" pyproject.toml -C 3 || echo "No entry points found" echo -e "\n=== Plugin imports or configurations ===" rg -l "plugin|entry_point" || echo "No plugin references found" # Check for any configuration files that might use dnstapir echo -e "\n=== Configuration files ===" fd -e yaml -e yml -e conf -e cfg -e toml -x echo "=== {} ===" \; -x cat {} \;Length of output: 5645
Summary by CodeRabbit
Chores
pre-commit-hooksfrom v4.5.0 to v5.0.0ruff-pre-commitfrom v0.8.2 to v0.8.6dnstapirdependency from v1.0.1 to v1.2.1, adding support forkeymanager.Removal