Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #17

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Update dependencies #17

merged 2 commits into from
Jan 22, 2025

Conversation

github-actions[bot]
Copy link
Contributor

This PR updates the dependencies to their latest versions.

The following changes were made from rebar3 update-deps --replace:

===> Looking for dependencies to update in rebar.config...
===> Nothing to update.

Updates from "rebar3 update-deps --replace":

===> Looking for dependencies to update in rebar.config...
===> Nothing to update.
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file. label Nov 20, 2024
@san983
Copy link
Member

san983 commented Jan 15, 2025

@whatyouhide QQ, is it ok to add back jsx when actually we are aiming to remove it?

@san983 san983 added the task Task to be performed label Jan 15, 2025
@weppos
Copy link
Member

weppos commented Jan 17, 2025

@whatyouhide QQ, is it ok to add back jsx when actually we are aiming to remove it?

Good catch. I wonder where it is coming from. Maybe a transitive dependency?

@whatyouhide
Copy link
Contributor

→ rebar3 tree
===> Verifying dependencies...
└─ erldns_admin─1.1.0 (project app)
   ├─ cowboy─2.12.0 (hex package)
   │  ├─ cowlib─2.13.0 (hex package)
   │  └─ ranch─1.8.0 (hex package)
   ├─ dns_erlang─1.1.0 (hex package)
   │  └─ base32─0.1.0 (hex package)
   ├─ erldns─1.0.0 (hex package)
   │  ├─ iso8601─1.3.4 (hex package)
   │  ├─ jsx─2.10.0 (hex package)
   │  └─ recon─2.5.5 (hex package)
   ├─ folsom─1.0.0 (hex package)
   │  └─ bear─1.0.0 (hex package)
   └─ lager─3.9.2 (hex package)
      └─ goldrush─0.1.9 (hex package)

Transitive dependeny yes. Until DNSimple will start properly using tags and publishing libs to Hex (instead of relying on Git commits for deps in other DNSimple deps) this will keep happening. I'll merge this one now to avoid it being open, and we can re-haul this stuff once DNSimple changes the tagging procedures.

@whatyouhide whatyouhide merged commit 04a2b26 into main Jan 22, 2025
2 checks passed
@whatyouhide whatyouhide deleted the update-deps-11934335358 branch January 22, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. task Task to be performed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants