Skip to content

Commit

Permalink
Remove tests/alt-fixtures/twine-1.5.0-py2.py3-none-any.whl
Browse files Browse the repository at this point in the history
This test file was added in 8b8790b (Add tests to ensure version
parsing does not regress, part of pypa#147) with the intent of testing the
target Python version from wheel file names.

However, the filename is identical to the one of the other text
fixture tests/fixtures/twine-1.5.0-py2.py3-none-any.whl thus it does
not appear to add any additional coverage to the code extracting the
target Python version.
  • Loading branch information
dnicolodi committed Dec 19, 2024
1 parent eb128f7 commit 22ad3ee
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
Binary file removed tests/alt-fixtures/twine-1.5.0-py2.py3-none-any.whl
Binary file not shown.
12 changes: 3 additions & 9 deletions tests/test_wheel.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,11 @@
from twine import exceptions
from twine import wheel

from . import helpers


@pytest.fixture(
params=[
"fixtures/twine-1.5.0-py2.py3-none-any.whl",
"alt-fixtures/twine-1.5.0-py2.py3-none-any.whl",
]
)
@pytest.fixture()
def example_wheel(request):
file_name = os.path.join(helpers.TESTS_DIR, request.param)
parent = pathlib.Path(__file__).parent
file_name = str(parent / "fixtures" / "twine-1.5.0-py2.py3-none-any.whl")
return wheel.Wheel(file_name)


Expand Down

0 comments on commit 22ad3ee

Please sign in to comment.