Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BlockRealTransportUnsafeMethods #100

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 2, 2024

For cases where we're running read-only tests, it is useful to have some extra guardrails to enforce that.

This PR introduces the BlockRealTransportUnsafeMethods option, which, when set to true, prevents any unsafe method from reaching RealTransport.

PS: having a new tag on merge like on #99 would be appreciated :-D

recorder/recorder.go Outdated Show resolved Hide resolved
recorder/recorder.go Outdated Show resolved Hide resolved
recorder/recorder.go Outdated Show resolved Hide resolved
recorder/recorder.go Outdated Show resolved Hide resolved
@ghost ghost force-pushed the add_safe_rt branch from 17bc119 to 9ab7c8f Compare August 6, 2024 09:27
@ghost ghost requested a review from dnaeon August 6, 2024 09:27
@dnaeon
Copy link
Owner

dnaeon commented Aug 8, 2024

Thanks!

@dnaeon dnaeon merged commit 90b25a8 into dnaeon:v3 Aug 8, 2024
2 checks passed
@ghost ghost deleted the add_safe_rt branch August 8, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant