Skip to content

Commit

Permalink
Fix bug in join command
Browse files Browse the repository at this point in the history
  • Loading branch information
WillHannon-MCB committed May 15, 2024
1 parent 7215f85 commit bfc53a1
Show file tree
Hide file tree
Showing 9 changed files with 29 additions and 14 deletions.
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -292,3 +292,21 @@
### Removed

- N/A

## [1.3.4] - 2024-05-15

### Added

- N/A

### Changed

- Fixes a bug where the markdown description was included in the count of keys compared to the number of input files causing the join command to exit before completing.

### Deprecated

- N/A

### Removed

- N/A
11 changes: 4 additions & 7 deletions configure_dms_viz/configure_dms_viz.py
Original file line number Diff line number Diff line change
Expand Up @@ -987,13 +987,10 @@ def join_command(input, output, description):
)
return

# Raise an error if the keys in the input files are not unique
if len(combined_data) != len(input):
click.secho(
"The keys in the input files are not unique. Please ensure that the keys are unique.",
fg="red",
)
return
# Raise an error if names of the datasets aren't unique
combined_data_keys = list(combined_data.keys())
if len(combined_data_keys) != len(set(combined_data_keys)):
raise ValueError("Names of the datasets are not unique.")

try:
# Write the combined data to the specified output file
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "configure-dms-viz"
version = "1.3.3"
version = "1.3.4"
description = "Configure your data for visualization with dms-viz.github.io"
authors = ["Will Hannon <[email protected]>"]
maintainers = ["Will Hannon <[email protected]>"]
Expand Down

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/IAV-PB1-DMS/output/IAV-PB1-DMS.json

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/SARS2-RBD-REGN-DMS/output/REGN mAb Cocktail.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/SARS2-RBD-REGN-DMS/output/SARS2-RBD-REGN-DMS.json

Large diffs are not rendered by default.

0 comments on commit bfc53a1

Please sign in to comment.