Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type checking to trigger model #1108

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

hinashi
Copy link
Contributor

@hinashi hinashi commented Mar 19, 2024

When using ForeignKey in a Django model, there was an issue where relation_name completion was not working.

Added type hints based on the issue below.
typeddjango/django-stubs#579 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 91.83673% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.66%. Comparing base (8df9939) to head (a8fd401).

Files Patch % Lines
trigger/models.py 91.48% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1108      +/-   ##
==========================================
+ Coverage   92.08%   96.66%   +4.58%     
==========================================
  Files         319      193     -126     
  Lines       27753    23065    -4688     
  Branches     1242        0    -1242     
==========================================
- Hits        25555    22296    -3259     
+ Misses       2098      769    -1329     
+ Partials      100        0     -100     
Flag Coverage Δ
core 96.66% <91.83%> (-0.02%) ⬇️
ui ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@userlocalhost userlocalhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving 👍

@userlocalhost userlocalhost merged commit 9651a21 into dmm-com:master Mar 21, 2024
2 checks passed
@userlocalhost userlocalhost deleted the feature/type_checking branch March 21, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants