Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More sklearn tag support. #11162

Merged
merged 3 commits into from
Jan 13, 2025
Merged

More sklearn tag support. #11162

merged 3 commits into from
Jan 13, 2025

Conversation

trivialfis
Copy link
Member

Close #11161 .

@trivialfis
Copy link
Member Author

cc @jameslamb

@trivialfis trivialfis mentioned this pull request Jan 13, 2025
Merged
@trivialfis
Copy link
Member Author

Please ignore the collective test failures for now, it's being tracked here #11154 .

@trivialfis trivialfis requested a review from hcho3 January 13, 2025 08:54
@trivialfis trivialfis mentioned this pull request Jan 13, 2025
Open
jameslamb
jameslamb approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me based on my read of https://github.com/scikit-learn/scikit-learn/blob/5b0ca3939854a3823beee6840b415a32ef16deb2/sklearn/utils/_tags.py

@trivialfis trivialfis merged commit d43c759 into dmlc:master Jan 13, 2025
57 of 58 checks passed
@trivialfis trivialfis deleted the skl-tags branch January 13, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@hcho3 hcho3 Awaiting requested review from hcho3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sklearn tags support.
2 participants
@trivialfis @jameslamb