[FEATURE] Alias per page #576
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 8, 2017 11:33
With this commit the page id is stored with each alias. So an alias can be used more than once as it is identified by the page on which the record is shown. With this commit the behaviour of aliases is similar to the beaviour of pages: The path segment is unique inside of the parent page.
While decoding preVars we have no page id, so we have to ignore it.
|
Not good, for example, if same news has to be shown on different pages. I do not see any value in this change. Also it breaks existing behavior. There has to be really good reasons to accept this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit the page id is stored with each alias. So an alias can be
used more than once as it is identified by the page on which the record is shown.
With this commit the behaviour of aliases is similar to the beaviour of pages:
The path segment is unique inside of the parent page, but can be used multiple times in a TYPO3 project.
While decoding preVars we have no page id, so we have to ignore it.