Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting image delivery channels to work with the default policy #944

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

JackLewis-digirati
Copy link
Contributor

@JackLewis-digirati JackLewis-digirati commented Jan 31, 2025

Resolves #931

This PR implements the new default delivery channel which does the following:

  • if default specified
    • if new asset, act like null delivery channel
    • if updated asset, ingest with customer specified default delivery channels
  • if null specified
    • if new asset, act the same as previous behavior
    • if updated asset, reuse the previous delivery channels

@JackLewis-digirati JackLewis-digirati changed the title getting image delivery channels to work with the default policy Getting image delivery channels to work with the default policy Feb 3, 2025
@JackLewis-digirati JackLewis-digirati marked this pull request as ready for review February 3, 2025 10:46
@JackLewis-digirati JackLewis-digirati requested a review from a team as a code owner February 3, 2025 10:46
@JackLewis-digirati JackLewis-digirati force-pushed the feature/optionalDeliveryChannels branch from ee4c0f5 to 0a7b789 Compare February 6, 2025 10:22
@JackLewis-digirati JackLewis-digirati merged commit b4afe60 into main Feb 6, 2025
10 checks passed
@JackLewis-digirati JackLewis-digirati deleted the feature/optionalDeliveryChannels branch February 6, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"deliveryChannels" should be optional for updates
2 participants