feat: command autocomplete #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlants
reviewed
Jan 27, 2025
| "paste-selection", | ||
| } | ||
|
|
||
| M.command_complete = function(_, line) |
There was a problem hiding this comment.
I'm not immediately following the logic here, I think I'll need to read it a bit more closely later. I think some more clear naming could help... or at least some comments explaining the shape of the objects we're expecting, or why we're mutating the parts table the way that we are.
There was a problem hiding this comment.
yeah the logic is more convoluted that I'd like ngl. I used lazy.nvim complete function as reference. I've added some comments to the code to explain what it's actually doing
alvarosevilla95
force-pushed
the
command-complete
branch
from
b6c24ed to
23c5a81
Compare
alvarosevilla95
force-pushed
the
command-complete
branch
from
23c5a81 to
7f7cfbf
Compare
dlants
added a commit
that referenced
this pull request
Feb 4, 2025
h/t to https://github.com/alvarosevilla95 for the initial PR #40
|
superseded by 9c5d051 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic completion for the
Magentacommand. This only completes the command action, but doesn't include advanced stuff like file completion forMagenta contexxt-files