-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated GermaNet API to version 13.1.0 #14
base: master
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
Jenkins, can you test this please? |
@reckart, this PR is going to make the tests fail on UKP's Jenkins instance because it has access only to GermaNet 7. Here's how you need to fix this:
|
@logological I've posted it to the folks and hope somebody reports back here : |
@logological the best option would be to create a mini dummy germanet for the unit test and to remove the depenency on having the actual germanet on the test server. |
This would be possible, though I think DKPro Similarity has GermaNet tests of its own that will need to be rewritten for the dummy GermaNet. |
Only when/if it is upgraded to a new DKPro LSR version ;) |
@reckart: Sorry, you've posted what to what folks? |
Solves #13