Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add The Dependencies To The Project #16

Open
wants to merge 3 commits into
base: cm-13.0
Choose a base branch
from

Conversation

adrian1234a
Copy link
Contributor

No description provided.

@adrian1234a
Copy link
Contributor Author

Hey @djeman you can revise this Please???

@djeman
Copy link
Owner

djeman commented Jul 23, 2017

Yep when I want ^^

I think you have not tested it because I do not see my repo name.
You need to test your modifications ...

An example :

{
    "remote": "github",
    "repository": "djeman/android_kernel_samsung_j3xnlte",
    "target_path": "kernel/samsung/j3xnlte"
}

Twrp omnirom repo not use "cm-13.0" branch but "android-6.0" so maybe there is a setting to choose the branch.

@adrian1234a
Copy link
Contributor Author

Finish :D

@djeman
Copy link
Owner

djeman commented Jul 24, 2017

It seems ok but have you try it ?

I need to finish my camera modifications and after I will merge it ;)
I make big change when I try to fix a hardware part so it's more easy to me to add it after.
I'm on the latest bug of the snap app maybe it's almost finish.

@djeman
Copy link
Owner

djeman commented Jul 24, 2017

You think it's a good idea to add my repositories in this file ?
I fear ^^
I do not see it on all others repo and maybe it's a problem when I'm working on this repo.
I launch very often the brunch command and I do not want any sync on my repo.

Edit: I'm always a noob to dev an android OS 🥇 ^^

@adrian1234a
Copy link
Contributor Author

Ok don't worry

@ghost
Copy link

ghost commented Oct 20, 2017

This is a quite useless because dependencies are working only on official supported devices, else it will make something like this in your manifest.xml :
"LineageOS/user/android_device_etc...." instead of "user/android_device_etc..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants