Show absolute amount of matching cards instead of percentage value

[ottowayne]

This makes it easier to see how similar the opponent's deck is compared to the selected one.
It shows the amount of cards played from the deck (right number) and the amount of played cards that actually matched the deck chosen by Advisor (left number).

Before:

After:

I am not 100% sure that all cards are counted. I used the IsCreated function to ignore cards that have been added by e.g. spells, but maybe there is more left to check.

[djdookie]

Hi @ottowayne,
thanks for your contribution.
I like the idea, but I'd prefer to have an option to switch between both presentations, so we can let the user decide.

Some spontaneous thoughts about that:
Since everything is based on the Jaccard (similarity) index, this exact value is displayed yet. And this is imho the best way for similarity calculation and should not be changed.
But I think you're right and it's more intuitive to display the number of matching cards together with the number of played cards instead of that similarity value by default.
One difference is the Jaccard index decreases if played cards are not matching. Initially I thought we would need a third value here, the number of not matching cards, to get the same information.
But since the difference of both numbers easily gives you that information, I support your approach. ;)

After a quick view on the code, I think "!opponentDeckCard.IsCreated" is obsolete, because it's based on opponentCardList, which doesn't contain created cards anymore:
IList<Card> opponentCardlist = Core.Game.Opponent.OpponentCardList.Where(x => !x.IsCreated).ToList();

Regarding jousted (revealed but not played) and discarded cards, your code should also be correct.

I will try to implement and test your pull request and add an option to switch back to the Jaccard presentation in the next days.

Thank you!

[djdookie]

Now, I included this feature in Release v1.0.5 1e3eeb0
I recognised that your counting was not correct, because you just counted the equalling card names, not the amount of equalling cards. This way, double cards weren't counted correctly.
My implementation went to a new extension method.
Additionally I implemented an option to switch back to the percentage, but the absolute similarity is turned on by default now.
Thanks again!

Cheers, Dookie.

[ottowayne]

Thanks for merging!
Another thing I thought about adding was tooltips for the Advisor cards, but that seems to be harder than I originally thought because HearthStoneDeckTracker does not offer generic functions for this.
One idea on how to implement this was to add a whole new Window and copy the functions used by HSDT for its own windows. But that was just an idea so far.

[djdookie]

Yeah, unfortunately there is no out-of-the-box mouseover support for HDT plugins.
I had a look into that very early and decided to skip that for now.
If HDT code changes regarding this or if you find an easy way to do this, let me know.
This feature was also proposed in #13.