Skip to content

Commit

Permalink
refactor(album-update): ♻️ import re for update_tools globally; check…
Browse files Browse the repository at this point in the history
… if book prefix is already on API side
  • Loading branch information
djdembeck committed Nov 24, 2021
1 parent 8523060 commit b7e0ec0
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
4 changes: 2 additions & 2 deletions Contents/Code/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def compile_metadata(self, helper):
# Description.
if not helper.metadata.summary or helper.force:
helper.metadata.summary = helper.description
tagger = TagTool(helper, Prefs, re)
tagger = TagTool(helper, Prefs)
# Genres.
tagger.add_genres()
# Title.
Expand Down Expand Up @@ -461,7 +461,7 @@ def compile_metadata(self, helper):
if helper.date is not None:
if not helper.metadata.originally_available_at or helper.force:
helper.metadata.originally_available_at = helper.date
tagger = TagTool(helper, Prefs, re)
tagger = TagTool(helper, Prefs)
# Genres.
tagger.add_genres()
# Narrators.
Expand Down
13 changes: 8 additions & 5 deletions Contents/Code/update_tools.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Import internal tools
from logging import Logging
import re

# Setup logger
log = Logging()
Expand Down Expand Up @@ -61,8 +62,11 @@ def parse_api_response(self, response):
self.title = response['title']

def volume_prefix(self, string):
prefixed_string = ('Book ' + string)
return prefixed_string
book_regex = '(Book ?(\d*\.)?\d+[+-]?[\d]?)'
if not re.match(book_regex, string):
prefixed_string = ('Book ' + string)
return prefixed_string
return string

# Writes metadata information to log.
def writeInfo(self):
Expand Down Expand Up @@ -152,10 +156,9 @@ def writeInfo(self):


class TagTool:
def __init__(self, helper, Prefs, re):
def __init__(self, helper, Prefs):
self.helper = helper
self.prefs = Prefs
self.re = re

def add_genres(self):
"""
Expand Down Expand Up @@ -186,7 +189,7 @@ def add_authors_to_moods(self):
self.helper.metadata.moods.clear()
# Loop through authors to check if it has contributor wording
for author in self.helper.author:
if not self.re.match(contributor_regex, author['name']):
if not re.match(contributor_regex, author['name']):
self.helper.metadata.moods.add(author['name'].strip())

def add_series_to_moods(self):
Expand Down

0 comments on commit b7e0ec0

Please sign in to comment.