Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed obsolete tests #1114

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Removed obsolete tests #1114

merged 2 commits into from
Dec 12, 2022

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Dec 12, 2022 •
edited
Loading

Relates to #468

Description of the Change

  • Format keys/field names is extensively tested in test_utils.py
  • test_factories.py simply tests functionality of another library, but nothing DJA specific

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc
Removed obsolete tests
eae48e4 
* Format keys/field names is extensively tested in test_utils
* Testing factories simply tests functionality of another library
  but nothing DJA specific
@sliverc sliverc requested a review from n2ygk December 12, 2022 18:24
@n2ygk n2ygk merged commit 5f48b70 into django-json-api:main Dec 12, 2022
@sliverc sliverc deleted the remove_obsolete_tests branch December 12, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliverc @n2ygk