Check if an object is still in index_queryset #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue where if an object is updated in a way that removes it from the index_queryset it does not get removed upon update. This can be fixed by overriding update_object or instead should_update to check if an object is no longer in the queryset and removing instead of updating.
|
if not self.index_queryset(**kwargs).filter(id=instance.id).exists(): |
|
what is ProjectIndex? |
bigjust
reviewed
Sep 28, 2017
| if instance.id not in ids: | ||
| self.remove_object(instance) | ||
| else: | ||
| super(ProjectIndex, self).update_object(instance, using, **kwargs) |
There was a problem hiding this comment.
This appears to be a project-specific subclass ProjectIndex
|
Is this still an issue? If so, can you provide a failing test for the test suite? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue where if an object is updated in a way that removes it from the index_queryset it does not get removed upon update. This can be fixed by overriding update_object or instead should_update to check if an object is no longer in the queryset and removing instead of updating.