Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

Commit

Permalink
Get rid of codecov 🙅
Browse files Browse the repository at this point in the history
  • Loading branch information
Jordan Mackie authored and Jordan Mackie committed Mar 11, 2023
1 parent a09e542 commit 816e978
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 56 deletions.
30 changes: 2 additions & 28 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ jobs:
release-version: v1.10.2
platform: ${{matrix.ninja-platform}}

# Build the Haskell lsp-test in its own step rather than as part of
# the integration test because tarpaulin will timeout
# Build the Haskell lsp-test in its own step so the stdout isn't swallowed by nextest.
#
# We don't currently run this test on Windows because I've not been able to
# get GitHub actions to properly cache Haskell stuff there and it takes
Expand All @@ -96,8 +95,7 @@ jobs:
if: matrix.os != 'windows-latest'
run: stack build ditto-lsp-test

- name: Run tests (without coverage)
if: matrix.os != 'ubuntu-latest'
- name: Run tests
uses: actions-rs/cargo@v1
with:
command: nextest
Expand All @@ -106,30 +104,6 @@ jobs:
DITTO_BUILD_GIT_DESCRIBE: "0.0.0-test"
DITTO_NINJA: ${{steps.install-ninja.outputs.which}}

- name: Install cargo-llvm-cov
# Only run tests with coverage if running on Linux
if: matrix.os == 'ubuntu-latest'
uses: taiki-e/install-action@cargo-llvm-cov

- name: Run tests (with coverage)
# Only run tests with coverage if running on Linux
if: matrix.os == 'ubuntu-latest'
uses: actions-rs/cargo@v1
with:
command: llvm-cov
args: --lcov --output-path lcov.info nextest --workspace
env:
DITTO_BUILD_GIT_DESCRIBE: "0.0.0-test"
DITTO_NINJA: ${{steps.install-ninja.outputs.which}}

- name: Upload coverage results to codecov.io 📡
if: matrix.os == 'ubuntu-latest'
uses: codecov/[email protected]
with:
token: ${{secrets.CODECOV_TOKEN}}
files: lcov.info
fail_ci_if_error: true

treefmt:
name: treefmt 💅
runs-on: ubuntu-latest
Expand Down
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@
<a href="https://github.com/ditto-lang/ditto/actions/workflows/security-audit.yaml">
<img src="https://github.com/ditto-lang/ditto/actions/workflows/security-audit.yaml/badge.svg?branch=main" alt="Security audit status">
</a>
<a href="https://codecov.io/gh/ditto-lang/ditto">
<img src="https://codecov.io/gh/ditto-lang/ditto/branch/main/graph/badge.svg?token=6TTRJO2KK0" alt="Code coverage badge"/>
</a>
<br><br>
<img src="./images/hello-ditto.svg" alt="Hello world program in ditto">
<br>
Expand Down
8 changes: 0 additions & 8 deletions codecov.yml

This file was deleted.

17 changes: 0 additions & 17 deletions shell.nix
Original file line number Diff line number Diff line change
Expand Up @@ -33,22 +33,6 @@ let
doCheck = false;
};

cargo-llvm-cov = pkgs.rustPlatform.buildRustPackage rec {
pname = "cargo-llvm-cov";
version = "0.5.0";
src = pkgs.fetchFromGitHub {
owner = "taiki-e";
repo = pname;
rev = "v${version}";
sha256 = "sha256-2O0MyL4SF/2AUpgWYUDWQ5dDpa84pwmnKGtAaWi5bwQ=";
};
cargoSha256 = "sha256-zQ1wgeKvc7q0pIx7ZWAQIayP/JVQGyFbLB3Iv81mbx0=";
cargoPatches = [
./cargo-llvm-cov-cargo-lock.patch
];
doCheck = false;
};

# Don't forget to update .github/actions/setup-haskell
stack = pkgs.symlinkJoin {
name = "stack-with-system-ghc";
Expand Down Expand Up @@ -80,7 +64,6 @@ pkgs.mkShell {
rustToolchain
rust-analyzer
pkgs.cargo-nextest
cargo-llvm-cov
pkgs.cargo-watch
pkgs.cargo-udeps
pkgs.cargo-audit
Expand Down

0 comments on commit 816e978

Please sign in to comment.