Fix URL encoding for input args

discosultan · Jan 14, 2018 · 6147afa · 6147afa
1 parent f9de124
commit 6147afa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/src/KrakenClient.cs b/src/KrakenClient.cs
@@ -256,7 +256,7 @@ private async Task<KrakenResponse<T>> SendRequest<T>(HttpRequestMessage req, int
 
         private static string UrlEncode(Dictionary<string, string> args) => string.Join(
             "&",
-            args.Where(x => x.Value != null).Select(x => x.Key + "=" + x.Value)
+            args.Where(x => x.Value != null).Select(x => x.Key + "=" + WebUtility.UrlEncode(x.Value))
         );
     }
 }
diff --git a/tests/KrakenClient.PrivateApi.Tests.cs b/tests/KrakenClient.PrivateApi.Tests.cs
@@ -190,6 +190,7 @@ public async Task AddStandardOrder()
                 "buy",
                 "market",
                 volume: 0.1m,
+                expireTime: "+60",
                 validate: true);
 
             AssertNotDefault(res.Result.Description.Order);

diff --git a/tests/KrakenClient.PublicApi.Tests.cs b/tests/KrakenClient.PublicApi.Tests.cs
@@ -122,6 +122,8 @@ public async Task GetOhlcData()
         [Fact]
         public async Task GetOrderBook()
         {
+            // Note, this can fail if the order book does not have any ask or bid orders for the pair.
+
             var res = await Client.GetOrderBook(DefaultPair);
 
             var orderBook = res.Result.First();