Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explorer): added arguments to select identified pattern types #447

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

lukasrothenberger
Copy link
Collaborator

No description provided.

@lukasrothenberger lukasrothenberger added enhancement New feature or request quick Does not take a lot of time labels Nov 24, 2023
@lukasrothenberger lukasrothenberger self-assigned this Nov 24, 2023
@goerlibe
Copy link
Collaborator

goerlibe commented Nov 29, 2023

more advanced and with some boilerplate code all around, but potentially more stable:

use a map (string->function) that has all the supported types and their run_.... functions.
the parser should then query the available suggestion types for the documentation string and validation.

this way, when we add more patterns, we know that the documentation stays up to date.

@lukasrothenberger lukasrothenberger merged commit f818228 into release/3.0.1 Nov 29, 2023
3 checks passed
@lukasrothenberger lukasrothenberger deleted the feat/explorer/select_pattern_types branch November 29, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quick Does not take a lot of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants