Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: assign unique ids to identified patterns #426

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Feature: assign unique ids to identified patterns #426

merged 2 commits into from
Oct 26, 2023

Conversation

lukasrothenberger
Copy link
Collaborator

closes #424

@lukasrothenberger lukasrothenberger self-assigned this Oct 25, 2023
@lukasrothenberger lukasrothenberger changed the base branch from master to release/3.0.0 October 25, 2023 14:38
@goerlibe
Copy link
Collaborator

Good idea with the blocking fileIO for synchronization. Unless there is an enormeous amount of patterns it should not have a huge impact on performance, right?

Also, just a suggestion: maybe group the functionality into a single function - or two if necessary. In that case maybe group them together by making them static methods of some class..
But then again maybe i am just overthinking it 😆

@lukasrothenberger lukasrothenberger merged commit d133ff3 into release/3.0.0 Oct 26, 2023
3 checks passed
@lukasrothenberger lukasrothenberger deleted the explorer/patterns/unique_ids branch October 26, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goerlibe goerlibe goerlibe approved these changes

Assignees

@lukasrothenberger lukasrothenberger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assign unique ids to identified patterns
2 participants
@lukasrothenberger @goerlibe