-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Talkto master #19
Open
thadzdingo
wants to merge
200
commits into
master
Choose a base branch
from
talkto-master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Talkto master #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evious transport which was tied into XMPPStream.
Now the 'to' attribute in the opening <stream> tag is set to the domain of the jid.
Private methods are not needed to be declared as long as they are used only after their definition is seen by the compiler.
This version seems to work for the P2P recipient example from ServerlessDemo.
Also remove XMPPReconnect for now. At a later point, we will integrate this with the socket transport.
…lling requests. A failed request schedules method |resendRequest:| after some delay. Therefore, while cancelling a request, we shud also cancel this scheduled execution of resending request.
Unfortunately we have to use associative references and not instance variables to cache these values. See note in the implementation of -[XMPPElement to] to understand why.
Presences to logverbose
Its ns->prefix gets deallocated for an unknown reason later on and crashes the app afterwards when we try to access an attribute of this NSXMLElement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.