Backend and frontend changes #2

ghoshbishakh · 2016-05-25T17:54:09Z

No description provided.

ghoshbishakh · 2016-05-25T17:54:19Z

more changes coming

…ring fixes dipy#3

simplemde-markdown-editor is used here because it is one of the best available js markdown editors and writing an editor from scratch will be reinventing the wheel. Instead this editor can be tweaked to suite our needs. https://github.com/NextStepWebs/simplemde-markdown-editor

This raises a security risk as any iframe can be embedded in this case fixes dipy#4 Causes dipy#5

fixes dipy#5 custom youtube filter replaces youtube links with embed codes while rendering views

fixes dipy#6

fixes dipy#7

jchoude · 2016-06-03T14:43:45Z

website/static/css/main.scss

+}
+
+
+// carousal-main styles


carousal -> carousel

Thanks for pointing. fixed

jchoude · 2016-06-03T14:50:57Z

Apart from my small comments, seems good. I'll wait on the fixes / replies to comments and on @Garyfallidis to merge this.

GJ 👍

Remove unnecessary custom filter loading in templates Remove duplicate registration of youtube_embed_url filter Fix typos

jchoude · 2016-06-15T12:59:36Z

website/models.py

+    url = models.CharField(max_length=200)
+    author = models.CharField(max_length=200)
+    doi = models.CharField(max_length=100, null=True, blank=True)
+    journal = models.CharField(max_length=200, null=True, blank=True)


How do you intend on keeping track of the type of publication (conference abstract, journal paper, etc)?

I have looked at bibtex of several publications but could not find any field that groups them as conference and journal paper. So I think we will have to enter it manually. I can provide a field for that.

I have added a field to keep track of publication type like book, article, inproceedings etc. in commit 60e95d4

jchoude · 2016-06-15T16:20:23Z

General question, which is related to the discussion we had earlier today: do we really need people to be able to modify the installation, overview, etc sections directly in the admin page using the editor? I'm not against it, I'm just wondering if it's really more complicated to just update the content in the page in the git repo, and just push that.

Again, maybe it's to make it easier for everyone to maintain. I don't remember if it was already discussed.

jchoude · 2016-06-15T16:22:16Z

website/views/manage_carousel.py

@@ -0,0 +1,120 @@
+from django.shortcuts import render, redirect


I don't remember if we agreed on using PEP8 for .py files, but normally imports should be ordered alphabetically.

I am trying to maintain PEP8 . So should the imports be like
from django.shortcuts import redirect, render

or is it with the other imports like

from website.forms import AddEditCarouselImageForm from website.models import CarouselImage from .tools import has_commit_permission

It is mainly to order each line, not necessarily the elements of each line. So, more like your second case.

Also, officially (https://www.python.org/dev/peps/pep-0008/#imports), if you look at the third point, they should be separated in 3 blocks: system / basic python imports first, then the third-party imports (like Django), and then the imports from the current project.

jchoude · 2016-06-15T16:33:53Z

Really good progress! Good job.

Also, quick note, I went quite fast through the CSS, because this is not something I can easily "view" just in my head, like this. The website has a nice layout and renders well on my setup, so that's a good first step.

…gs, book etc

pages can be created edited and deleted fixed sections are fixed and can only be edited

jchoude · 2016-06-21T13:15:50Z

Ok. @ghoshbishakh I don't know if you have any other commits lined-up for this PR, but it is getting quite huge. I'd like to merge it, else it will not be reviewable. So, please tell me if you absolutely need to add other commits, or if I can make another quick review of the new commits, and then merge.

Also, for your next work, please make sure you create branches, instead of working in your master branch. That will make the workflow easier. You will also be able to make quick, small branches, leading to small PRs.

ghoshbishakh · 2016-06-21T13:20:01Z

You may merge it. I will make a separate PR for the rest of the changes
from a new branch.

On Tue, Jun 21, 2016 at 6:45 PM, Jean-Christophe Houde <
[email protected]> wrote:

Ok. @ghoshbishakh https://github.com/ghoshbishakh I don't know if you
have any other commits lined-up for this PR, but it is getting quite huge.
I'd like to merge it, else it will not be reviewable. So, please tell me if
you absolutely need to add other commits, or if I can make another quick
review of the new commits, and then merge.

Also, for your next work, please make sure you create branches, instead of
working in your master branch. That will make the workflow easier. You will
also be able to make quick, small branches, leading to small PRs.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AE6vs81JVD9R_poYHjKIlYI4BeVGt-KEks5qN-QGgaJpZM4ImzY8
.

jchoude · 2016-06-21T14:47:32Z

Cool, thanks. I went through the last commits after the previous review I made. A batch of questions or issues. For issues, you can tag them in the issue tracker and tackle them after the merge. I will merge, but you still can (and should) answer my questions here.

When I edit a page / section, the lines, words count at the bottom of the editor always shows 0 until I start editing. Then, they show the correct values. It's a very minor issue.
In dashboard/sections/page/, it would be nice to have less content, i.e., not show the whole pages' content. Either a small part of the beginning of the page, or just the title of the page. That way, we don't need to scroll endlessly to get to the edit button of the installation page, for example.
Remember to set debug=False in your settings before we release the page in the wild. It is set to true on Heroku...
On the current version on Heroku, there is nothing in the G+ feed. Expected?
I saw that, in one commit, you added a separate honeycomb page. There is also the support page, with gitter support. There only is the support page that I can reach, and only by clicking on the icon in the front page. I would personnally put it in the navbar.
The "Install now" icon in the index currently points to a dead link for the installation page.
For my personal knowledge, what is the difference when using the .scss file instead of the .css one?

ghoshbishakh · 2016-06-21T15:01:21Z

I will look into it why it shows 0 atfirst.
I will truncate the posts after a certain length then.
Yes in production there is a pretty long checklist to follow. That includes turning debug off.
Google plus api requires to put trusted IP addresses. I am still unable to find one for heroku. It is working locally for me. I hope heroku gives a static ip.
Currently there are too many links in the navbar. I am thinking of using drop down menus instead of single links.
Missed that. WIll change that in next commit.
Scss has some extra features like nesting, mixing, variables etc. The one I use most is nesting. I plan to include vendor specific prefix mixing (-webkit, -moz, etc.) later.

Disallow null values for website_position_id in WebsiteSection

fb166e4

ghoshbishakh added 12 commits May 25, 2016 23:37

Add more tags to bleach whitelist necessary for proper markdown rende…

ea36417

…ring fixes dipy#3

Add simplemde editor in addsection view

434328a

Add iframe to bleach whitelist to enable youtube embeds

c4ef021

This raises a security risk as any iframe can be embedded in this case fixes dipy#4 Causes dipy#5

Write custom template filter for converting youtube links to embeds

8a573de

Remove iframe from bleach whitelist and use custom filter

49a2a7b

fixes dipy#5 custom youtube filter replaces youtube links with embed codes while rendering views

Style youtube embedded player

4b8d41e

fixes dipy#6

Add news edit and add views and rearrange dashboard

dc9f42b

Display news date in home page

e84590a

Add datetime picker plugin

c7e773a

Add simple carousel in index page

24f0500

Make youtube embeds responsive

9668e6a

fixes dipy#7

jchoude reviewed Jun 3, 2016
View reviewed changes

ghoshbishakh added 8 commits June 4, 2016 09:15

Add publication models and views

4df14ae

Bug Fixes

a6bc969

Remove unnecessary custom filter loading in templates Remove duplicate registration of youtube_embed_url filter Fix typos

Make views.py a module as it was getting large.

5412492

Make single templete for add/edit news

0bb1ca9

Add publication entry using bibtex

71e879f

Remove edit publication from index page

9d247b6

Display publications with bibtex in cite page

91f1148

Add delete option for publications

7a3c3d9

ghoshbishakh changed the title ~~Disallow null values for website_position_id in WebsiteSection~~ Backend changes, mostly for admin panel and cms Jun 6, 2016

ghoshbishakh added 3 commits June 7, 2016 12:50

Add delete link for news

62f6249

Add is_highlighted field to Publication model

c08b288

Add highlight publication views

25c11e5

jchoude reviewed Jun 15, 2016
View reviewed changes

ghoshbishakh added 6 commits June 16, 2016 11:27

Add field to keep track of publication type like article, inproceedin…

60e95d4

…gs, book etc

Fix wrong comments in templates

cd92dc8

Use current year as the last year in copyright text in footer

5315bdb

Add unused comments and codes used before for debugging

94dc3fc

Categorize sections into pages and fixed

dd80ecd

pages can be created edited and deleted fixed sections are fixed and can only be edited

Write custom template context preprocessor to display pages in navbar

9c38f6e

ghoshbishakh changed the title ~~Backend changes, mostly for admin panel and cms~~ Backend and frontend changes Jun 18, 2016

ghoshbishakh added 3 commits June 20, 2016 00:49

Add basic google plus feed fetching

e956399

Add separate honeycomb gallery

3aba94b

Add support page with gitter frame and mailing list links

eceb3c2

jchoude merged commit e5e8d04 into dipy:master Jun 21, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backend and frontend changes #2

Backend and frontend changes #2

ghoshbishakh commented May 25, 2016

ghoshbishakh commented May 25, 2016

jchoude Jun 3, 2016

ghoshbishakh Jun 4, 2016

jchoude commented Jun 3, 2016 •

edited

Loading

jchoude Jun 15, 2016

ghoshbishakh Jun 15, 2016

ghoshbishakh Jun 16, 2016 •

edited

Loading

jchoude commented Jun 15, 2016

jchoude Jun 15, 2016

ghoshbishakh Jun 16, 2016

jchoude Jun 16, 2016

jchoude commented Jun 15, 2016

jchoude commented Jun 21, 2016

ghoshbishakh commented Jun 21, 2016

jchoude commented Jun 21, 2016

ghoshbishakh commented Jun 21, 2016

		@@ -0,0 +1,120 @@
		from django.shortcuts import render, redirect

Backend and frontend changes #2

Backend and frontend changes #2

Conversation

ghoshbishakh commented May 25, 2016

ghoshbishakh commented May 25, 2016

jchoude Jun 3, 2016

Choose a reason for hiding this comment

ghoshbishakh Jun 4, 2016

Choose a reason for hiding this comment

jchoude commented Jun 3, 2016 • edited Loading

jchoude Jun 15, 2016

Choose a reason for hiding this comment

ghoshbishakh Jun 15, 2016

Choose a reason for hiding this comment

ghoshbishakh Jun 16, 2016 • edited Loading

Choose a reason for hiding this comment

jchoude commented Jun 15, 2016

jchoude Jun 15, 2016

Choose a reason for hiding this comment

ghoshbishakh Jun 16, 2016

Choose a reason for hiding this comment

jchoude Jun 16, 2016

Choose a reason for hiding this comment

jchoude commented Jun 15, 2016

jchoude commented Jun 21, 2016

ghoshbishakh commented Jun 21, 2016

jchoude commented Jun 21, 2016

ghoshbishakh commented Jun 21, 2016

jchoude commented Jun 3, 2016 •

edited

Loading

ghoshbishakh Jun 16, 2016 •

edited

Loading