mailsmtp: Allow authentication without SASL. #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libetpan currently does not allow authentication at all, without USE_SASL, which is an unnecessary limitation and a serious impediment to the usability of the SMTP portion of the library. This fix is twofold: * Uncomment and export mailsmtp_auth_login, for AUTH LOGIN. * Export commands for sending custom commands and reading responses (which is already possible with the IMAP library, so consistent with that). This is necessary for sending custom AUTH commands parts of other AUTH commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libetpan currently does not allow authentication at all, without USE_SASL, which is an unnecessary limitation and a serious impediment to the usability of the SMTP portion of the library. This fix is twofold: