Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use alias in annotation #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable use alias in annotation #53

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 11, 2017

use Dingo\Blueprint\Annotation as BP;
use Dingo\Blueprint\Annotation\Method as BPM;

/**

  • @bp\Resource("Test")
    /
    class TestController extends Controller
    {
    /
    *
    • Ask for new service
    • @bpm\Get("/test")
    • @bp\Versions({"v1"})
      */
      public function test(){
      }
      }

use Dingo\Blueprint\Annotation as BP;
use Dingo\Blueprint\Annotation\Method as BPM;

/**
 * @bp\Resource("Test")
 */
class TestController extends Controller
{
    /**
     * Ask for new service
     *
     * @bpm\Get("/test")
     * @bp\Versions({"v1"})
     */
     public function test(){
     }
}
@qrazi
Copy link

qrazi commented Feb 8, 2017

Would definitely like to be able to use namespace aliases. And as far as I can see, that is not possible with the SimpleAnnotationReader. However, perhaps this PR should be changed to have Blueprint depend on the Reader interface and have the actual implementation class configurable. Neater in general an perhaps the motivation for using SimpleAnnotationReader was for performance reasons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant