Replace FromJSON instance for EntryId to fix failing test
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the derived
FromJSONinstance forEntryIdwith a hand-written instance that is exactly parallel to the existing instance forTradeId, which is also a newtype overWord64. This fixes the failinggetUSDAccountLedgertest; see #18.I don't know when or why this test started to fail. It seems odd that the instances for
EntryIdandTradeIdwere different. I believe Coinbase's JSON has used strings for everything, including numbers, as long as I've been paying attention.We can merge this now or wait to see whether there's anything we can do to fix the rest of the tests, whatever you think makes sense.