Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clone_scaled to Shape traits #217

Merged
merged 6 commits into from
Jul 20, 2024
Merged

Add clone_scaled to Shape traits #217

merged 6 commits into from
Jul 20, 2024

Conversation

Neo-Zhixing
Copy link
Contributor

We currently have some generic logic for scaling Shape in bevy_rapier. It seems reasonable to put this in the Shape trait so that the same logic can be reused elsewhere.

@Neo-Zhixing Neo-Zhixing mentioned this pull request Jul 2, 2024
Open
@Vrixyz Vrixyz requested a review from sebcrozet July 5, 2024 14:45
sebcrozet
sebcrozet requested changes Jul 11, 2024
View reviewed changes
Copy link
Member

@sebcrozet sebcrozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! Having this in parry directly sounds convenient.

src/shape/shape.rs Outdated Show resolved Hide resolved
@Neo-Zhixing Neo-Zhixing requested a review from sebcrozet July 11, 2024 18:50
@sebcrozet sebcrozet merged commit 5479a8d into dimforge:master Jul 20, 2024
5 checks passed
@sebcrozet
Copy link
Member

Thanks!

@Neo-Zhixing Neo-Zhixing deleted the clone-scaled branch July 20, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebcrozet sebcrozet sebcrozet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Neo-Zhixing @sebcrozet